Skip to content

feat(tri): gates prs — a conflicting PR loses its path-filtered CI (#2492) - #2546

Merged
gHashTag merged 1 commit into
masterfrom
feat/gates-prs
Aug 23, 2026
Merged

gHashTag merged 1 commit into
masterfrom
feat/gates-prs

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

#2543 left one pull request's missing CI undiagnosed. Checking every open pull request found the mechanism — and then the mechanism corrected itself.

Three more pull requests have the same shape

Two of them change bootstrap/src/compiler.rs and got three checks: check-linked-issue, GitGuardian, NotebookLM. Every one path-less.

That file's gate carries this comment, written to prevent exactly this:

Without bootstrap/** here, a PR that rewrites the C emitter merges with the cross-target proof never running.

The path was added. The gate is defeated by a merge conflict instead.

The mechanism

A pull request that is CONFLICTING when an event fires cannot have its merge diff computed, so paths: filters cannot be evaluated and only path-less workflows run. The checks that remain are green — they are the ones that never look at the diff — which reads exactly like a passing pull request.

And the rule I first wrote was wrong

The correlation looked exact: four conflicting pull requests with 3, 3, 9 and 7 checks; everything else 21 to 35. I wrote "a CONFLICTING pull request loses most of its checks" into the tool's own documentation.

An hour later two of those four reported 21 and 26. They had been mergeable when their events fired, kept those results, and only conflicted afterwards. A conflict does not retract past runs.

So the detectable shape is not the state. It is conflicting and a check list far below its siblings' — the command now computes a reference from the non-conflicting pull requests rather than asserting from the state alone. Three flagged, two correctly excluded.

Caught by re-running the command on fresher data, not by thinking harder. That is the argument for putting a finding into a tool rather than a document: a sentence cannot disagree with tomorrow's data; a command can.

And it crashed on its first run

Slicing a title by byte index, in the middle of an em dash — in a pull request this campaign had opened. Truncate by chars.

Refs #2492

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-23 12:57:56 UTC

Summary

Status Count
Total Open PRs 8
PRs with Failing Checks 4
PRs with All Checks Green 4
READY 3
FAILING 4
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 9cef5bd into master Aug 23, 2026
29 of 31 checks passed
@gHashTag
gHashTag deleted the feat/gates-prs branch August 23, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant